Re: [PATCH v8 44/45] target/arm: Add allocation tag storage for system mode

[Richard Henderson]

On 6/25/20 6:03 AM, Peter Maydell wrote:
> On Tue, 23 Jun 2020 at 20:38, Richard Henderson
> <richard.henderson@linaro.org> wrote:
>>
>> Look up the physical address for the given virtual address,
>> convert that to a tag physical address, and finally return
>> the host address that backs it.
>>
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>> ---
>>  target/arm/mte_helper.c | 126 ++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 126 insertions(+)
>>
> 
>> +    /* If not normal memory, there is no tag storage: access unchecked. */
>> +    if (unlikely(flags & TLB_MMIO)) {
> 
> Comment says we're checking a memory attribute, but the code
> is checking for TLB_MMIO, which isn't the same thing.

Comment is not trying to allude to Normal vs Device, but "ram" vs "mmio" in the
qemu sense.


r~