qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 03/25] Clean up some calls to ignore Error objects the rig


From: Markus Armbruster
Subject: Re: [PATCH v2 03/25] Clean up some calls to ignore Error objects the right way
Date: Thu, 25 Jun 2020 08:42:51 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Greg Kurz <groug@kaod.org> writes:

> On Wed, 24 Jun 2020 10:37:15 +0200
> Markus Armbruster <armbru@redhat.com> wrote:
>
>> Receiving the error in a local variable only to free it is less clear
>> (and also less efficient) than passing NULL.  Clean up.
>> 
>> Cc: Daniel P. Berrange <berrange@redhat.com>
>> Cc: Jerome Forissier <jerome@forissier.org>
>> CC: Greg Kurz <groug@kaod.org>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>
> It doesn't seem to be different from v1, so:

I missed your reply to v1.  My apologies!

> Reviewed-by: Greg Kurz <groug@kaod.org>
>
> and
>
> Acked-by: Greg Kurz <groug@kaod.org> # for 9pfs

Thanks!




reply via email to

[Prev in Thread] Current Thread [Next in Thread]