[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 41/46] qdev: Make functions taking Error ** return bool, not void
From: |
Markus Armbruster |
Subject: |
[PATCH 41/46] qdev: Make functions taking Error ** return bool, not void |
Date: |
Wed, 24 Jun 2020 18:43:39 +0200 |
See recent commit "error: Document Error API usage rules" for
rationale.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
include/hw/qdev-properties.h | 4 ++--
hw/core/qdev-properties-system.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h
index 49c6cd2460..f12ab9e6bc 100644
--- a/include/hw/qdev-properties.h
+++ b/include/hw/qdev-properties.h
@@ -236,8 +236,8 @@ extern const PropertyInfo qdev_prop_pcie_link_width;
/*
* Set properties between creation and realization.
*/
-void qdev_prop_set_drive_err(DeviceState *dev, const char *name,
- BlockBackend *value, Error **errp);
+bool qdev_prop_set_drive_err(DeviceState *dev, const char *name,
+ BlockBackend *value, Error **errp);
/*
* Set properties between creation and realization.
diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c
index abd851656f..3e4f16fc21 100644
--- a/hw/core/qdev-properties-system.c
+++ b/hw/core/qdev-properties-system.c
@@ -413,7 +413,7 @@ const PropertyInfo qdev_prop_audiodev = {
.set = set_audiodev,
};
-void qdev_prop_set_drive_err(DeviceState *dev, const char *name,
+bool qdev_prop_set_drive_err(DeviceState *dev, const char *name,
BlockBackend *value, Error **errp)
{
const char *ref = "";
@@ -428,7 +428,7 @@ void qdev_prop_set_drive_err(DeviceState *dev, const char
*name,
}
}
- object_property_set_str(OBJECT(dev), name, ref, errp);
+ return object_property_set_str(OBJECT(dev), name, ref, errp);
}
void qdev_prop_set_drive(DeviceState *dev, const char *name,
--
2.26.2
- Re: [PATCH 45/46] qdev: Ignore Error objects where the return value suffices, (continued)
- [PATCH 46/46] hmp: Ignore Error objects where the return value suffices, Markus Armbruster, 2020/06/24
- [PATCH 32/46] qom: Rename qdev_get_type() to object_get_type(), Markus Armbruster, 2020/06/24
- [PATCH 21/46] hmp: Eliminate a variable in hmp_migrate_set_parameter(), Markus Armbruster, 2020/06/24
- [PATCH 29/46] acpi: Avoid unnecessary error_propagate() after error_setg(), Markus Armbruster, 2020/06/24
- [PATCH 41/46] qdev: Make functions taking Error ** return bool, not void,
Markus Armbruster <=
- [PATCH 19/46] block: Avoid unnecessary error_propagate() after error_setg(), Markus Armbruster, 2020/06/24
- [PATCH 36/46] qom: Put name parameter before value / visitor parameter, Markus Armbruster, 2020/06/24
- [PATCH 22/46] qapi: Make visitor functions taking Error ** return bool, not void, Markus Armbruster, 2020/06/24
- [PATCH 42/46] qdev: Smooth error checking with Coccinelle, Markus Armbruster, 2020/06/24