qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/5] target/i386: implement special cases for fxtract


From: Joseph Myers
Subject: Re: [PATCH 1/5] target/i386: implement special cases for fxtract
Date: Tue, 23 Jun 2020 22:00:30 +0000
User-agent: Alpine 2.21 (DEB 202 2017-01-01)

On Tue, 23 Jun 2020, Eduardo Habkost wrote:

> > +        if (EXPD(temp) == 0) {
> > +            int shift = clz64(temp.l.lower);
> > +            temp.l.lower <<= shift;
> 
> Coverity reports the following.  It looks like a false positive
> because floatx80_is_zero() would be true if both EXPD(temp) and
> temp.l.lower were zero, but maybe I'm missing something.

Yes, that looks like a false positive to me.

-- 
Joseph S. Myers
joseph@codesourcery.com



reply via email to

[Prev in Thread] Current Thread [Next in Thread]