qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 25/25] ppc64: Clean up reginfo handling


From: Alex Bennée
Subject: Re: [PATCH v3 25/25] ppc64: Clean up reginfo handling
Date: Tue, 23 Jun 2020 18:45:12 +0100
User-agent: mu4e 1.5.3; emacs 28.0.50

Richard Henderson <richard.henderson@linaro.org> writes:

> Several of the gp_reg[] elements are not relevant -- e.g. orig r3,
> which is related to system calls.  Omit those from the original
> reginfo_init(), so that any differences are automatically hidden.
>
> Do not only compare bit 4 of CCR -- this register is 32 bits wide
> with 8 cr subfields.  We should compare all of them.
>
> Tidy reginfo_dump() output.  Especially, do not dump the non-
> relevant fields.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

I guess this means any traces that exist will need to be redone?

Anyway with your hotfix:

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée



reply via email to

[Prev in Thread] Current Thread [Next in Thread]