Re: [PATCH v10 0/5] fw_cfg: Add FW_CFG_DATA_GENERATOR; crypto: Add tls-cipher-suites

[Philippe Mathieu-Daudé]

On 6/23/20 7:27 PM, Philippe Mathieu-Daudé wrote:
> Hi,
> 
> This series has 3 parts:
> 
> - First we add the tls-cipher-suites object
> 
> - We add the ability to QOM objects to produce data
>   consumable by the fw_cfg device,
> 
> - Then we let the tls-cipher-suites object implement
>   the FW_CFG_DATA_GENERATOR interface.
> 
> This is required by EDK2 'HTTPS Boot' feature [*] to tell
> the guest which TLS ciphers it can use.
> 
> Since v9:
> - intent to address Daniel suggestions, rewrite of crypto/* code

I forgot to explain the huge diff due to the rewrite.
Daniel suggested to simplify the API by returning a GByteArray:

https://www.mail-archive.com/qemu-devel@nongnu.org/msg712887.html
https://www.mail-archive.com/qemu-devel@nongnu.org/msg712923.html

> $ git backport-diff -u v9
> Key:
> [----] : patches are identical
> [####] : number of functional differences between upstream/downstream patch
> [down] : patch is downstream-only
> The flags [FC] indicate (F)unctional and (C)ontextual differences, 
> respectively
> 
> 001/5:[0139] [FC] 'crypto: Add tls-cipher-suites object'
> 002/5:[0052] [FC] 'hw/nvram/fw_cfg: Add the FW_CFG_DATA_GENERATOR interface'
> 003/5:[0010] [FC] 'softmmu/vl: Let -fw_cfg option take a 'gen_id' argument'
> 004/5:[----] [--] 'softmmu/vl: Allow -fw_cfg 'gen_id' option to use the 
> 'etc/' namespace'
> 005/5:[0018] [FC] 'crypto/tls-cipher-suites: Produce fw_cfg consumable blob'