Re: [PULL 00/16] Qdev patches for 2020-06-23

[no-reply]

Patchew URL: 
20200623142326.2349416-1-armbru@redhat.com/">https://patchew.org/QEMU/20200623142326.2349416-1-armbru@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL 00/16] Qdev patches for 2020-06-23
Type: series
Message-id: 20200623142326.2349416-1-armbru@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20200623142326.2349416-1-armbru@redhat.com -> 
patchew/20200623142326.2349416-1-armbru@redhat.com
Switched to a new branch 'test'
ac67def sd/milkymist-memcard: Fix error API violation
76b782c sd/pxa2xx_mmci: Don't crash on pxa2xx_mmci_init() error
086cf2b arm/aspeed: Drop aspeed_board_init_flashes() parameter @errp
6bd670c qdev: Make qdev_prop_set_drive() match the other helpers
7eeac9e qdev: Reject chardev property override
ce015be qdev: Reject drive property override
4add9a8 qdev: Improve netdev property override error a bit
cb55c6b qdev: Eliminate get_pointer(), set_pointer()
6047192 blockdev: Deprecate -drive with bogus interface type
a895f7e docs/qdev-device-use.txt: Update section "Default Devices"
b16a9dd fdc: Deprecate configuring floppies with -global isa-fdc
21ae90a fdc: Open-code fdctrl_init_isa()
7f28ea2 fdc: Reject clash between -drive if=floppy and -global isa-fdc
32abd1e iotests/172: Cover -global floppy.drive=...
94d87e4 iotests/172: Cover empty filename and multiple use of drives
e86ed08 iotests/172: Include "info block" in test output

=== OUTPUT BEGIN ===
1/16 Checking commit e86ed08dd590 (iotests/172: Include "info block" in test 
output)
2/16 Checking commit 94d87e4b70d9 (iotests/172: Cover empty filename and 
multiple use of drives)
ERROR: trailing whitespace
#49: FILE: tests/qemu-iotests/172.out:190:
+Testing: -fdb $

total: 1 errors, 0 warnings, 86 lines checked

Patch 2/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/16 Checking commit 32abd1e271de (iotests/172: Cover -global floppy.drive=...)
4/16 Checking commit 7f28ea2d0fb3 (fdc: Reject clash between -drive if=floppy 
and -global isa-fdc)
5/16 Checking commit 21ae90a939a0 (fdc: Open-code fdctrl_init_isa())
6/16 Checking commit b16a9dd79300 (fdc: Deprecate configuring floppies with 
-global isa-fdc)
7/16 Checking commit a895f7e560a7 (docs/qdev-device-use.txt: Update section 
"Default Devices")
8/16 Checking commit 6047192a60b6 (blockdev: Deprecate -drive with bogus 
interface type)
9/16 Checking commit cb55c6b9560c (qdev: Eliminate get_pointer(), set_pointer())
10/16 Checking commit 4add9a82e120 (qdev: Improve netdev property override 
error a bit)
11/16 Checking commit ce015be44e23 (qdev: Reject drive property override)
12/16 Checking commit 7eeac9e4aac8 (qdev: Reject chardev property override)
13/16 Checking commit 6bd670c596a9 (qdev: Make qdev_prop_set_drive() match the 
other helpers)
14/16 Checking commit 086cf2b3fbe7 (arm/aspeed: Drop 
aspeed_board_init_flashes() parameter @errp)
15/16 Checking commit 76b782c8fe16 (sd/pxa2xx_mmci: Don't crash on 
pxa2xx_mmci_init() error)
16/16 Checking commit ac67def4dfa7 (sd/milkymist-memcard: Fix error API 
violation)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20200623142326.2349416-1-armbru@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20200623142326.2349416-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com