qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 15/25] Rearrange reginfo and memblock buffers


From: Alex Bennée
Subject: Re: [PATCH v3 15/25] Rearrange reginfo and memblock buffers
Date: Tue, 23 Jun 2020 09:47:55 +0100
User-agent: mu4e 1.5.3; emacs 28.0.50

Richard Henderson <richard.henderson@linaro.org> writes:

> For send_register_info from master_sigill, do not keep a
> reginfo buffer on the stack.  At the moment, this struct
> is quite large for aarch64.
>
> Put the two reginfo buffers into an array, for the benefit
> of future dumping.  For recv_and_compare_register_info,
> index this array with constants, so it's a simple rename.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
<snip>
> @@ -221,7 +228,6 @@ static RisuResult recv_and_compare_register_info(void *uc)
>      default:
>          abort();
>      }
> -
>      return res;
>  }

nit: stray whitespace change

Otherwise:

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée



reply via email to

[Prev in Thread] Current Thread [Next in Thread]