[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/22] tests: Use &error_abort where appropriate
From: |
Thomas Huth |
Subject: |
Re: [PATCH 04/22] tests: Use &error_abort where appropriate |
Date: |
Mon, 22 Jun 2020 13:26:33 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 22/06/2020 12.42, Markus Armbruster wrote:
> Receiving the error in a local variable only to assert there is none
> is less clear than passing &error_abort. Clean up.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> tests/check-qobject.c | 5 +-
> tests/test-logging.c | 12 +---
> tests/test-qemu-opts.c | 22 ++----
> tests/test-replication.c | 109 +++++++++--------------------
> tests/test-string-input-visitor.c | 33 +++------
> tests/test-string-output-visitor.c | 16 ++---
> 6 files changed, 57 insertions(+), 140 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
- [PATCH 00/22] Error handling fixes & cleanups, Markus Armbruster, 2020/06/22
- [PATCH 09/22] sd/milkymist-memcard: Plug minor memory leak in realize, Markus Armbruster, 2020/06/22
- [PATCH 04/22] tests: Use &error_abort where appropriate, Markus Armbruster, 2020/06/22
- Re: [PATCH 04/22] tests: Use &error_abort where appropriate,
Thomas Huth <=
- [PATCH 10/22] test-util-filemonitor: Plug unlikely memory leak, Markus Armbruster, 2020/06/22
- [PATCH 03/22] Clean up some calls to ignore Error objects the right way, Markus Armbruster, 2020/06/22
- [PATCH 14/22] qdev: Drop qbus_set_bus_hotplug_handler() parameter @errp, Markus Armbruster, 2020/06/22
- [PATCH 05/22] tests: Use error_free_or_abort() where appropriate, Markus Armbruster, 2020/06/22
- [PATCH 08/22] qga: Plug unlikely memory leak in guest-set-memory-blocks, Markus Armbruster, 2020/06/22
- [PATCH 15/22] qdev: Drop qbus_set_hotplug_handler() parameter @errp, Markus Armbruster, 2020/06/22
- [PATCH 19/22] riscv_hart: Fix riscv_harts_realize() error API violations, Markus Armbruster, 2020/06/22