Re: Re: [PATCH] chardev/tcp: fix error message double free error

[lichun]

>Hi
>
>On Sun, Jun 21, 2020 at 10:54 AM lichun <lichun@ruijie.com.cn> wrote:
>>
>> Signed-off-by: lichun <lichun@ruijie.com.cn>
>> ---
>>  chardev/char-socket.c | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/chardev/char-socket.c b/chardev/char-socket.c
>> index afebeec5c3..3b6c1c5848 100644
>> --- a/chardev/char-socket.c
>> +++ b/chardev/char-socket.c
>> @@ -1086,7 +1086,10 @@ static void qemu_chr_socket_connected(QIOTask *task, 
>> void *opaque)
>>      if (qio_task_propagate_error(task, &err)) {
>>          tcp_chr_change_state(s, TCP_CHARDEV_STATE_DISCONNECTED);
>>          check_report_connect_error(chr, err);
>> -        error_free(err);
>> +        /* If connect_err_reported is true, it means err is already freed */
>> +        if (!s->connect_err_reported) {
>> +            error_free(err);
>> +        }
>
>Good catch (did you find it with a static analysis tool?). 
Yeah, I find it with gdb.

>
>Instead of checking connect_err_reported here, I would rather let
>check_report_connect_error() handle error_free(). Can you update the
>patch? 
Of course, I will.
>
>thanks
>
>>          goto cleanup;
>>      }
>>
>> --
>> 2.18.4
>>
>