[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] target/arm: Remove unnecessary gen_io_end() calls
From: |
Richard Henderson |
Subject: |
Re: [PATCH] target/arm: Remove unnecessary gen_io_end() calls |
Date: |
Fri, 19 Jun 2020 17:23:03 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 6/19/20 10:03 AM, Peter Maydell wrote:
> Since commit ba3e7926691ed3 it has been unnecessary for target code
> to call gen_io_end() after an IO instruction in icount mode; it is
> sufficient to call gen_io_start() before it and to force the end of
> the TB.
>
> Many now-unnecessary calls to gen_io_end() were removed in commit
> 9e9b10c6491153b, but some were missed or accidentally added later.
> Remove unneeded calls from the arm target:
>
> * the call in the handling of exception-return-via-LDM is
> unnecessary, and the code is already forcing end-of-TB
> * the call in the VFP access check code is more complicated:
> we weren't ending the TB, so we need to add the code to
> force that by setting DISAS_UPDATE
> * the doc comment for ARM_CP_IO doesn't need to mention
> gen_io_end() any more
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> target/arm/cpu.h | 2 +-
> target/arm/translate-vfp.inc.c | 7 +++----
> target/arm/translate.c | 3 ---
> 3 files changed, 4 insertions(+), 8 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~