|
| From: | Richard Henderson |
| Subject: | Re: [PATCH] qga: Use gethostname() instead of g_get_host_name() |
| Date: | Fri, 19 Jun 2020 14:54:10 -0700 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 6/16/20 1:34 AM, Michal Privoznik wrote: > +#ifndef G_OS_WIN32 Nit: positive tests are easier to reason with and extend than negative tests. I would reverse these two blocks and use a positive test for windows. Also, CONFIG_WIN32 is what we use elsewhere for this test. r~
| [Prev in Thread] | Current Thread | [Next in Thread] |