Re: [PATCH] Deprecate TileGX port

[Thomas Huth]

On 19/06/2020 17.48, Peter Maydell wrote:
> Deprecate our TileGX target support:
>  * we have no active maintainer for it
>  * it has had essentially no contributions (other than tree-wide cleanups
>    and similar) since it was first added
>  * the Linux kernel dropped support in 2018, as has glibc
> 
> Note the deprecation in the manual, but don't try to print a warning
> when QEMU runs -- printing unsuppressable messages is more obtrusive
> for linux-user mode than it would be for system-emulation mode, and
> it doesn't seem worth trying to invent a new suppressible-error
> system for linux-user just for this.

I wonder whether anybody will notice the deprecation note in the manual
only, though. If we want to find out whether there are still any users
left, I think printing an unsuppressable message would be better... or
maybe something like:

    if (!getenv("QEMU_SUPPRESS_TILEGX_DEPRECATION_WARNING")) {
        fprintf(stderr, "Warning: TileGX CPU support is deprecated and "
                        "will be removed soon!\n"
                        "Set QEMU_SUPPRESS_TILEGX_DEPRECATION_WARNING "
                        "environment variable to hide this warning.");
    }

?

> diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
> index 3a255591c34..e9097e089bb 100644
> --- a/docs/system/deprecated.rst
> +++ b/docs/system/deprecated.rst
> @@ -387,6 +387,17 @@ The above, converted to the current supported format::
>  
>    json:{"file.driver":"rbd", "file.pool":"rbd", "file.image":"name"}
>  
> +linux-user mode CPUs
> +--------------------
> +
> +``tilegx`` CPUs (since 5.1.0)
> +'''''''''''''''''''''''''''''
> +
> +The ``tilegx`` guest CPU support (which was only implemented in
> +linux-user mode) is deprecated and will be removed in a future version
> +of QEMU. Support for this CPU was removed from the upstream Linux
> +kernel in 2018, and has also been dropped from glibc.

Reviewed-by: Thomas Huth <thuth@redhat.com>