[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v9 06/10] Makefile: Write MINIKCONF variables as one entry per li
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v9 06/10] Makefile: Write MINIKCONF variables as one entry per line |
Date: |
Thu, 18 Jun 2020 14:33:38 +0200 |
Having one entry per line helps reviews/refactors. As we are
going to modify the MINIKCONF variables, split them now to
ease further review.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Makefile | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/Makefile b/Makefile
index 0d9ef87e6d..b7f41a2ef2 100644
--- a/Makefile
+++ b/Makefile
@@ -418,12 +418,15 @@ MINIKCONF_ARGS = \
CONFIG_LINUX=$(CONFIG_LINUX) \
CONFIG_PVRDMA=$(CONFIG_PVRDMA)
-MINIKCONF_INPUTS = $(SRC_PATH)/Kconfig.host $(SRC_PATH)/hw/Kconfig
-MINIKCONF_DEPS = $(MINIKCONF_INPUTS) $(wildcard $(SRC_PATH)/hw/*/Kconfig)
+MINIKCONF_INPUTS = $(SRC_PATH)/Kconfig.host \
+ $(SRC_PATH)/hw/Kconfig
+MINIKCONF_DEPS = $(MINIKCONF_INPUTS) \
+ $(wildcard $(SRC_PATH)/hw/*/Kconfig)
MINIKCONF = $(PYTHON) $(SRC_PATH)/scripts/minikconf.py
$(SUBDIR_DEVICES_MAK): %/config-devices.mak: default-configs/%.mak
$(MINIKCONF_DEPS) $(BUILD_DIR)/config-host.mak
- $(call quiet-command, $(MINIKCONF) $(MINIKCONF_ARGS) > $@.tmp, "GEN",
"$@.tmp")
+ $(call quiet-command, $(MINIKCONF) $(MINIKCONF_ARGS) \
+ > $@.tmp, "GEN", "$@.tmp")
$(call quiet-command, if test -f $@; then \
if cmp -s $@.old $@; then \
mv $@.tmp $@; \
--
2.21.3
- [PATCH v9 02/10] MAINTAINERS: Add an 'overall' entry for accelerators, (continued)
[PATCH v9 05/10] Makefile: Remove dangerous EOL trailing backslash, Philippe Mathieu-Daudé, 2020/06/18
[PATCH v9 06/10] Makefile: Write MINIKCONF variables as one entry per line,
Philippe Mathieu-Daudé <=
[PATCH v9 07/10] accel/Kconfig: Extract accel selectors into their own config, Philippe Mathieu-Daudé, 2020/06/18
[PATCH v9 08/10] accel/Kconfig: Add the TCG selector, Philippe Mathieu-Daudé, 2020/06/18
[PATCH v9 09/10] Makefile: Allow target-specific optional Kconfig, Philippe Mathieu-Daudé, 2020/06/18
[PATCH v9 10/10] accel/tcg: Add stub for probe_access(), Philippe Mathieu-Daudé, 2020/06/18
Re: [PATCH v9 00/10] accel: Allow targets to use Kconfig, no-reply, 2020/06/18
Re: [PATCH v9 00/10] accel: Allow targets to use Kconfig, Philippe Mathieu-Daudé, 2020/06/22