Re: [PATCH 0/3] Add Scripts for Finding Top 25 Executed Functions

[Alex Bennée]

Eric Blake <eblake@redhat.com> writes:

> On 6/16/20 6:12 PM, Ahmed Karaman wrote:
>> Greetings,
>> 
>> As a part of the TCG Continous Benchmarking project for GSoC this
>> year, detailed reports discussing different performance measurement
>> methodologies and analysis results will be sent here on the mailing
>> list.
>> 
>> The project's first report is currently being revised and will be
>> posted on the mailing list in the next few days.
>> A section in this report will deal with measuring the top 25 executed
>> functions when running QEMU. It includes two Python scripts that
>> automatically perform this task.
>> 
>> This series adds these two scripts to a new performance directory
>> created under the scripts directory. It also adds a new
>> "Miscellaneous" section to the end of the MAINTAINERS file with a
>> "Performance Tools and Tests" subsection.
>> 
>> Best regards,
>> Ahmed Karaman
>> 
>> Ahmed Karaman (3):
>>    MAINTAINERS: Add 'Miscellaneous' section
>>    scripts/performance: Add callgrind_top_25.py script
>>    scripts/performance: Add perf_top_25.py script
>> 
>>   MAINTAINERS                             |  7 ++
>>   scripts/performance/callgrind_top_25.py | 95 +++++++++++++++++++++++++
>>   scripts/performance/perf_top_25.py      | 82 +++++++++++++++++++++
>>   3 files changed, 184 insertions(+)
>>   create mode 100644 scripts/performance/callgrind_top_25.py
>>   create mode 100644 scripts/performance/perf_top_25.py
>
> Are the new scripts supposed to have executable permissions, or are they 
> always invoked as 'python path/to/script.py' where the executable bit is 
> less important?

I would assume +x for directly invocable scripts - certainly we have a
lot of those in the scripts directory. 

-- 
Alex Bennée