Re: [PATCH v2] trace/simple: Fix unauthorized enable

[Stefan Hajnoczi]

On Wed, May 27, 2020 at 08:56:13AM +0200, Markus Armbruster wrote:
> st_set_trace_file() accidentally enables tracing.  It's called
> unconditionally during startup, which is why QEMU built with the
> simple trace backend always writes a trace file "trace-$PID".
> 
> This has been broken for quite a while.  I didn't track down the exact
> commit.
> 
> Fix st_set_trace_file() to restore the state.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> v2: Make st_set_trace_file() less confusing [Stefan]
> 
>  trace/simple.h |  2 +-
>  trace/simple.c | 20 ++++++++++++++------
>  2 files changed, 15 insertions(+), 7 deletions(-)

Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing

Stefan

signature.asc
Description: PGP signature