[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 2/7] block/nvme: drop tautologous assertion
From: |
Stefan Hajnoczi |
Subject: |
[PATCH v2 2/7] block/nvme: drop tautologous assertion |
Date: |
Wed, 17 Jun 2020 14:21:56 +0100 |
nvme_process_completion() explicitly checks cid so the assertion that
follows is always true:
if (cid == 0 || cid > NVME_QUEUE_SIZE) {
...
continue;
}
assert(cid <= NVME_QUEUE_SIZE);
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Sergio Lopez <slp@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
block/nvme.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/block/nvme.c b/block/nvme.c
index e4375ec245..d567ece3f4 100644
--- a/block/nvme.c
+++ b/block/nvme.c
@@ -336,7 +336,6 @@ static bool nvme_process_completion(BDRVNVMeState *s,
NVMeQueuePair *q)
cid);
continue;
}
- assert(cid <= NVME_QUEUE_SIZE);
trace_nvme_complete_command(s, q->index, cid);
preq = &q->reqs[cid - 1];
req = *preq;
--
2.26.2
- [PATCH v2 0/7] block/nvme: support nested aio_poll(), Stefan Hajnoczi, 2020/06/17
- [PATCH v2 1/7] block/nvme: poll queues without q->lock, Stefan Hajnoczi, 2020/06/17
- [PATCH v2 2/7] block/nvme: drop tautologous assertion,
Stefan Hajnoczi <=
- [PATCH v2 3/7] block/nvme: don't access CQE after moving cq.head, Stefan Hajnoczi, 2020/06/17
- [PATCH v2 4/7] block/nvme: switch to a NVMeRequest freelist, Stefan Hajnoczi, 2020/06/17
- [PATCH v2 5/7] block/nvme: clarify that free_req_queue is protected by q->lock, Stefan Hajnoczi, 2020/06/17
- [PATCH v2 6/7] block/nvme: keep BDRVNVMeState pointer in NVMeQueuePair, Stefan Hajnoczi, 2020/06/17
- [PATCH v2 7/7] block/nvme: support nested aio_poll(), Stefan Hajnoczi, 2020/06/17
- Re: [PATCH v2 0/7] block/nvme: support nested aio_poll(), Stefan Hajnoczi, 2020/06/23