[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 2/4] microvm: drop max-ram-below-4g support
From: |
Gerd Hoffmann |
Subject: |
[PULL 2/4] microvm: drop max-ram-below-4g support |
Date: |
Wed, 17 Jun 2020 14:28:59 +0200 |
Not useful for microvm and allows users to shoot themself
into the foot (make ram + mmio overlap).
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Message-id: 20200529073957.8018-3-kraxel@redhat.com
---
hw/i386/microvm.c | 19 -------------------
1 file changed, 19 deletions(-)
diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c
index 44f940813b07..5e931975a06d 100644
--- a/hw/i386/microvm.c
+++ b/hw/i386/microvm.c
@@ -173,25 +173,6 @@ static void microvm_memory_init(MicrovmMachineState *mms)
ram_addr_t lowmem = 0xc0000000; /* 3G */
int i;
- /*
- * Handle the machine opt max-ram-below-4g. It is basically doing
- * min(qemu limit, user limit).
- */
- if (!x86ms->max_ram_below_4g) {
- x86ms->max_ram_below_4g = 4 * GiB;
- }
- if (lowmem > x86ms->max_ram_below_4g) {
- lowmem = x86ms->max_ram_below_4g;
- if (machine->ram_size - lowmem > lowmem &&
- lowmem & (1 * GiB - 1)) {
- warn_report("There is possibly poor performance as the ram size "
- " (0x%" PRIx64 ") is more then twice the size of"
- " max-ram-below-4g (%"PRIu64") and"
- " max-ram-below-4g is not a multiple of 1G.",
- (uint64_t)machine->ram_size, x86ms->max_ram_below_4g);
- }
- }
-
if (machine->ram_size > lowmem) {
x86ms->above_4g_mem_size = machine->ram_size - lowmem;
x86ms->below_4g_mem_size = lowmem;
--
2.18.4
- [PULL 0/4] Microvm 20200617 patches, Gerd Hoffmann, 2020/06/17
- [PULL 4/4] microvm: move virtio base to 0xfeb00000, Gerd Hoffmann, 2020/06/17
- [PULL 3/4] x86: move max-ram-below-4g to pc, Gerd Hoffmann, 2020/06/17
- [PULL 2/4] microvm: drop max-ram-below-4g support,
Gerd Hoffmann <=
- [PULL 1/4] microvm: use 3G split unconditionally, Gerd Hoffmann, 2020/06/17
- Re: [PULL 0/4] Microvm 20200617 patches, no-reply, 2020/06/17
- Re: [PULL 0/4] Microvm 20200617 patches, Peter Maydell, 2020/06/18