Re: [PATCH v2] hmp: Make json format optional for qom-set

[Dr. David Alan Gilbert]

* David Hildenbrand (david@redhat.com) wrote:
> On 10.06.20 12:39, Dr. David Alan Gilbert wrote:
> > * David Hildenbrand (david@redhat.com) wrote:
> >> On 10.06.20 09:51, David Hildenbrand wrote:
> >>> Commit 7d2ef6dcc1cf ("hmp: Simplify qom-set") switched to the json
> >>> parser, making it possible to specify complex types. However, with this
> >>> change it is no longer possible to specify proper sizes (e.g., 2G, 128M),
> >>> turning the interface harder to use for properties that consume sizes.
> >>>
> >>> Let's switch back to the previous handling and allow to specify passing
> >>> json via the "-j" parameter.
> >>>
> >>> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> >>> Cc: Markus Armbruster <armbru@redhat.com>
> >>> Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
> >>> Cc: Paolo Bonzini <pbonzini@redhat.com>
> >>> Cc: "Daniel P. Berrangé" <berrange@redhat.com>
> >>> Cc: Eduardo Habkost <ehabkost@redhat.com>
> >>> Signed-off-by: David Hildenbrand <david@redhat.com>
> >>> ---
> >>> v1 - v2:
> >>> - keep the "value:S" as correctly noted by Paolo :)
> >>> ---
> >>>  hmp-commands.hx    |  7 ++++---
> >>>  qom/qom-hmp-cmds.c | 20 ++++++++++++++++----
> >>>  2 files changed, 20 insertions(+), 7 deletions(-)
> >>>
> >>> diff --git a/hmp-commands.hx b/hmp-commands.hx
> >>> index 28256209b5..5d12fbeebe 100644
> >>> --- a/hmp-commands.hx
> >>> +++ b/hmp-commands.hx
> >>> @@ -1806,9 +1806,10 @@ ERST
> >>>  
> >>>      {
> >>>          .name       = "qom-set",
> >>> -        .args_type  = "path:s,property:s,value:S",
> >>> -        .params     = "path property value",
> >>> -        .help       = "set QOM property",
> >>> +        .args_type  = "json:-j,path:s,property:s,value:S",
> >>> +        .params     = "[-j] path property value",
> >>> +        .help       = "set QOM property.\n\t\t\t"
> >>> +                      "-j: the property is specified in json format.",
> >>
> >> Stupid mistake:
> >>
> >> "-j: the value is specified in json format
> > 
> > oops; can fix that in commit
> 
> Perfect, let me know in case you need a respin. Thanks!

I've queued this; if we can come up with something nicer to meet
Markus's suggestions that would be great, but for now we get the
functionality back.

> 
> -- 
> Thanks,
> 
> David / dhildenb
> 
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK