Re: [PATCH 1/3] MAINTAINERS: Add 'Miscellaneous' section

[Aleksandar Markovic]

среда, 17. јун 2020., Ahmed Karaman <ahmedkhaledkaraman@gmail.com> је написао/ла:
> This new section includes the 'Performance Tools and Tests' subsection
> which will contain the the performance scripts and benchmarks written
> as a part of the 'TCG Continuous Benchmarking' project.
>
> Signed-off-by: Ahmed Karaman <ahmedkhaledkaraman@gmail.com>
> ---
>  MAINTAINERS | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 955cc8dd5c..68f668ae2a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2974,3 +2974,10 @@ M: Peter Maydell <peter.maydell@linaro.org>
>  S: Maintained
>  F: docs/conf.py
>  F: docs/*/conf.py
> +
> +Miscellaneous
> +-------------
> +Performance Tools and Tests
> +M: Ahmed Karaman <ahmedkhaledkaraman@gmail.com>
> +S: Maintained
> +F: scripts/performance/
> \ No newline at end of file
> --

I don't think that it makes any functional difference in this case, but it is customary that the last line of any source file contains end-of-line characters, so please add that in the next version of the series.

Also, I think it is more logical that this patch is the last patch in the series - if left the way you proposed, this patch would refer to the directory that does not exist - yet.

Otherwise, it looks good to me.

Section "Miscellaneous" makes sense to me.

Thanks,

Aleksandar

 

> 2.17.1