Re: [PATCH v4 1/7] MAINTAINERS: Cover 'hw/sh4/sh_intc.h' with the R2D machine

[Philippe Mathieu-Daudé]

On 6/16/20 3:34 PM, Thomas Huth wrote:
> On 11/06/2020 13.43, Philippe Mathieu-Daudé wrote:
>> Commit 81527b94ad added hw/intc/sh_intc.c, complete by
>> adding its corresponding header.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>>  MAINTAINERS | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 13711aafe8..87ceca7ff1 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1257,6 +1257,7 @@ S: Maintained
>>  F: hw/sh4/r2d.c
>>  F: hw/intc/sh_intc.c
>>  F: hw/timer/sh_timer.c
>> +F: include/hw/sh4/sh_intc.h
>>  
>>  Shix
>>  M: Yoshinori Sato <ysato@users.sourceforge.jp>
> 
> Hmm, sh_intc.h is used by sh7750_init() in sh7750.c ... and that
> function is used by both, r2d and shix machines ... so should that maybe
> rather be part of both machines or a generic entry?

I'll add it to both machines. The maintainers can reorder
the sections later.

Thanks for the review!

> 
>  Thomas
> 
>