[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 10/21] translate-all: call qemu_spin_destroy for PageDesc
From: |
Alex Bennée |
Subject: |
[PULL 10/21] translate-all: call qemu_spin_destroy for PageDesc |
Date: |
Tue, 16 Jun 2020 13:53:13 +0100 |
From: "Emilio G. Cota" <cota@braap.org>
The radix tree is append-only, but we can fail to insert
a PageDesc if the insertion races with another thread.
Signed-off-by: Emilio G. Cota <cota@braap.org>
Signed-off-by: Robert Foley <robert.foley@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20200609200738.445-8-robert.foley@linaro.org>
Message-Id: <20200612190237.30436-11-alex.bennee@linaro.org>
diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c
index c937210e217..c3d37058a17 100644
--- a/accel/tcg/translate-all.c
+++ b/accel/tcg/translate-all.c
@@ -547,6 +547,15 @@ static PageDesc *page_find_alloc(tb_page_addr_t index, int
alloc)
#endif
existing = atomic_cmpxchg(lp, NULL, pd);
if (unlikely(existing)) {
+#ifndef CONFIG_USER_ONLY
+ {
+ int i;
+
+ for (i = 0; i < V_L2_SIZE; i++) {
+ qemu_spin_destroy(&pd[i].lock);
+ }
+ }
+#endif
g_free(pd);
pd = existing;
}
--
2.20.1
- [PULL 06/21] thread: add qemu_spin_destroy, (continued)
- [PULL 06/21] thread: add qemu_spin_destroy, Alex Bennée, 2020/06/16
- [PULL 04/21] configure: add --enable-tsan flag + fiber annotations for coroutine-ucontext, Alex Bennée, 2020/06/16
- [PULL 02/21] Makefile: dtc: update, build the libfdt target, Alex Bennée, 2020/06/16
- [PULL 05/21] cpu: convert queued work to a QSIMPLEQ, Alex Bennée, 2020/06/16
- [PULL 07/21] cputlb: destroy CPUTLB with tlb_destroy, Alex Bennée, 2020/06/16
- [PULL 13/21] include/qemu: Added tsan.h for annotations., Alex Bennée, 2020/06/16
- [PULL 14/21] util: Added tsan annotate for thread name., Alex Bennée, 2020/06/16
- [PULL 08/21] qht: call qemu_spin_destroy for head buckets, Alex Bennée, 2020/06/16
- [PULL 09/21] tcg: call qemu_spin_destroy for tb->jmp_lock, Alex Bennée, 2020/06/16
- [PULL 12/21] tests/docker: Added docker build support for TSan., Alex Bennée, 2020/06/16
- [PULL 10/21] translate-all: call qemu_spin_destroy for PageDesc,
Alex Bennée <=
- [PULL 21/21] plugins: new lockstep plugin for debugging TCG changes, Alex Bennée, 2020/06/16
- [PULL 11/21] thread: add tsan annotations to QemuSpin, Alex Bennée, 2020/06/16
- [PULL 19/21] tests/tcg: build plugin list from contents of src directory, Alex Bennée, 2020/06/16
- [PULL 15/21] docs: Added details on TSan to testing.rst, Alex Bennée, 2020/06/16
- [PULL 18/21] cirrus.yml: serialise make check, Alex Bennée, 2020/06/16
- [PULL 16/21] tests: Disable select tests under TSan, which hit TSan issue., Alex Bennée, 2020/06/16
- [PULL 17/21] Revert ".shippable: temporaily disable some cross builds", Alex Bennée, 2020/06/16
- [PULL 20/21] tests/tcg: ensure -cpu max also used for plugin run, Alex Bennée, 2020/06/16