[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v3 7/8] vhost-vdpa: introduce vhost-vdpa backend
From: |
Laurent Vivier |
Subject: |
Re: [RFC v3 7/8] vhost-vdpa: introduce vhost-vdpa backend |
Date: |
Mon, 15 Jun 2020 16:44:07 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 08/06/2020 22:14, Eric Blake wrote:
> On 5/29/20 9:06 AM, Cindy Lu wrote:
>> From: Tiwei Bie <tiwei.bie@intel.com>
>
> The original author is Tiwei Bie...
>
>>
>> Currently we have 2 types of vhost backends in QEMU: vhost kernel and
>> vhost-user. The above patch provides a generic device for vDPA purpose,
>> this vDPA device exposes to user space a non-vendor-specific
>> configuration
>> interface for setting up a vhost HW accelerator, this patch set
>> introduces
>> a third vhost backend called vhost-vdpa based on the vDPA interface.
>>
>> Vhost-vdpa usage:
>>
>> qemu-system-x86_64 -cpu host -enable-kvm \
>> ......
>> -netdev type=vhost-vdpa,vhostdev=/dev/vhost-vdpa-id,id=vhost-vdpa0 \
>> -device virtio-net-pci,netdev=vhost-vdpa0,page-per-vq=on \
>>
>> Co-Authored-By: Lingshan zhu <lingshan.zhu@intel.com>
>> Signed-off-by: Cindy Lu <lulu@redhat.com>
>> ---
>
> ...but there is no S-o-b here. Also, Co-Authored-By is an unusual tag;
> it's just as easy to spell it Signed-off-by even for co-authors.
>
Normally the tag to use in this case is "Co-developed-by".
https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by
"A Co-Developed-by: states that the patch was also created by another
developer along with the original author. This is useful at times when
multiple people work on a single patch. Note, this person also needs to
have a Signed-off-by: line in the patch as well."
Thanks,
Laurent
- Re: [RFC v3 7/8] vhost-vdpa: introduce vhost-vdpa backend, (continued)
- Re: [RFC v3 7/8] vhost-vdpa: introduce vhost-vdpa backend, Cindy Lu, 2020/06/03
- Re: [RFC v3 7/8] vhost-vdpa: introduce vhost-vdpa backend, Jason Wang, 2020/06/02
- Re: [RFC v3 7/8] vhost-vdpa: introduce vhost-vdpa backend, Jason Wang, 2020/06/03
- Re: [RFC v3 7/8] vhost-vdpa: introduce vhost-vdpa backend, Eugenio Perez Martin, 2020/06/04
- Re: [RFC v3 7/8] vhost-vdpa: introduce vhost-vdpa backend, Eric Blake, 2020/06/08