[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v1 10/18] translate-all: call qemu_spin_destroy for PageDesc
From: |
Alex Bennée |
Subject: |
[PATCH v1 10/18] translate-all: call qemu_spin_destroy for PageDesc |
Date: |
Fri, 12 Jun 2020 20:02:29 +0100 |
From: "Emilio G. Cota" <cota@braap.org>
The radix tree is append-only, but we can fail to insert
a PageDesc if the insertion races with another thread.
Signed-off-by: Emilio G. Cota <cota@braap.org>
Signed-off-by: Robert Foley <robert.foley@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20200609200738.445-8-robert.foley@linaro.org>
---
accel/tcg/translate-all.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c
index c937210e217..c3d37058a17 100644
--- a/accel/tcg/translate-all.c
+++ b/accel/tcg/translate-all.c
@@ -547,6 +547,15 @@ static PageDesc *page_find_alloc(tb_page_addr_t index, int
alloc)
#endif
existing = atomic_cmpxchg(lp, NULL, pd);
if (unlikely(existing)) {
+#ifndef CONFIG_USER_ONLY
+ {
+ int i;
+
+ for (i = 0; i < V_L2_SIZE; i++) {
+ qemu_spin_destroy(&pd[i].lock);
+ }
+ }
+#endif
g_free(pd);
pd = existing;
}
--
2.20.1
- [PATCH v1 01/18] tests/docker: bump fedora to 32, (continued)
- [PATCH v1 01/18] tests/docker: bump fedora to 32, Alex Bennée, 2020/06/12
- [PATCH v1 02/18] Makefile: dtc: update, build the libfdt target, Alex Bennée, 2020/06/12
- [PATCH v1 03/18] Makefile: remove old compatibility gunks, Alex Bennée, 2020/06/12
- [PATCH v1 04/18] configure: add --enable-tsan flag + fiber annotations for coroutine-ucontext, Alex Bennée, 2020/06/12
- [PATCH v1 05/18] cpu: convert queued work to a QSIMPLEQ, Alex Bennée, 2020/06/12
- [PATCH v1 12/18] tests/docker: Added docker build support for TSan., Alex Bennée, 2020/06/12
- [PATCH v1 06/18] thread: add qemu_spin_destroy, Alex Bennée, 2020/06/12
- [PATCH v1 08/18] qht: call qemu_spin_destroy for head buckets, Alex Bennée, 2020/06/12
- [PATCH v1 07/18] cputlb: destroy CPUTLB with tlb_destroy, Alex Bennée, 2020/06/12
- [PATCH v1 09/18] tcg: call qemu_spin_destroy for tb->jmp_lock, Alex Bennée, 2020/06/12
- [PATCH v1 10/18] translate-all: call qemu_spin_destroy for PageDesc,
Alex Bennée <=
- [PATCH v1 11/18] thread: add tsan annotations to QemuSpin, Alex Bennée, 2020/06/12
- [PATCH v1 14/18] util: Added tsan annotate for thread name., Alex Bennée, 2020/06/12
- [PATCH v1 17/18] Revert ".shippable: temporaily disable some cross builds", Alex Bennée, 2020/06/12
- [PATCH v1 18/18] cirrus.yml: serialise make check, Alex Bennée, 2020/06/12
- [PATCH v1 13/18] include/qemu: Added tsan.h for annotations., Alex Bennée, 2020/06/12
- [PATCH v1 15/18] docs: Added details on TSan to testing.rst, Alex Bennée, 2020/06/12
- [PATCH v1 16/18] tests: Disable select tests under TSan, which hit TSan issue., Alex Bennée, 2020/06/12
- Re: [PATCH v1 00/18] testing/next (tsan, dtc warnings, cross-builds), no-reply, 2020/06/12