[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/1] util/getauxval: Porting to FreeBSD getauxval feature
From: |
Laurent Vivier |
Subject: |
Re: [PATCH 1/1] util/getauxval: Porting to FreeBSD getauxval feature |
Date: |
Fri, 12 Jun 2020 09:13:22 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
Le 11/06/2020 à 23:10, David CARLIER a écrit :
>
Hi,
please don't put your patch in attachements, you can use "git
send-email" if your emailer doesn't allow it.
https://wiki.qemu.org/Contribute/SubmitAPatch#Do_not_send_as_an_attachment
I think your patch is not correct, you put a "#if defined(__linux__)" in
a block that is followed by "#elif defined(__linux__)" and there is no
return value if none of the "defined()" is true.
I think you should not modify the configure and add directly a "#if
defined(__FreeBSD__)" at the beginning of getauxval.c to define your
function.
Thanks,
Laurent