qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 08/10] target/arm: Convert Neon VEXT to decodetree


From: Richard Henderson
Subject: Re: [PATCH 08/10] target/arm: Convert Neon VEXT to decodetree
Date: Thu, 11 Jun 2020 09:26:52 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0

On 6/11/20 7:45 AM, Peter Maydell wrote:
> Convert the Neon VEXT insn to decodetree. Rather than keeping the
> old implementation which used fixed temporaries cpu_V0 and cpu_V1
> and did the extraction with by-hand shift and logic ops, we use
> the TCG extract2 insn.
> 
> We don't need to special case 0 or 8 immediates any more as the
> optimizer is smart enough to throw away the dead code.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  target/arm/neon-dp.decode       |  8 +++-
>  target/arm/translate-neon.inc.c | 76 +++++++++++++++++++++++++++++++++
>  target/arm/translate.c          | 58 +------------------------
>  3 files changed, 85 insertions(+), 57 deletions(-)

Nice cleanup.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~




reply via email to

[Prev in Thread] Current Thread [Next in Thread]