qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/8] hw/tpm: Do not include 'qemu/osdep.h' in header


From: Stefan Berger
Subject: Re: [PATCH 1/8] hw/tpm: Do not include 'qemu/osdep.h' in header
Date: Thu, 11 Jun 2020 07:55:20 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 6/10/20 4:02 PM, Philippe Mathieu-Daudé wrote:
 From CODING_STYLE.rst:

   Do not include "qemu/osdep.h" from header files since the .c
   file will have already included it.

Remove "qemu/osdep.h" from "tpm_tis.h".

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>


Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>


---
  hw/tpm/tpm_tis.h | 1 -
  1 file changed, 1 deletion(-)

diff --git a/hw/tpm/tpm_tis.h b/hw/tpm/tpm_tis.h
index 5554989395..f6b5872ba6 100644
--- a/hw/tpm/tpm_tis.h
+++ b/hw/tpm/tpm_tis.h
@@ -24,7 +24,6 @@
  #ifndef TPM_TPM_TIS_H
  #define TPM_TPM_TIS_H
-#include "qemu/osdep.h"
  #include "sysemu/tpm_backend.h"
  #include "tpm_ppi.h"





reply via email to

[Prev in Thread] Current Thread [Next in Thread]