Re: [PATCH 1/1] MAINTAINERS: Adjust sh4 maintainership

[Aleksandar Markovic]

чет, 11. јун 2020. у 10:25 Thomas Huth <thuth@redhat.com> је написао/ла:
>
> On 11/06/2020 00.17, Aleksandar Markovic wrote:
> > This patch transfers sh4 sections to Yoshinori Sato, who is best
> > positioned in the community to assume their maintainership. He is
> > the maintainer of the related target rx.
> >
> > Further adjustments, reorganizations, and improvements of sh4
> > sections are left to the future maintainer to be devised and
> > executed, as he deems suitable.
> >
> > Aurealien and Magnus are deleted from some sections from the
> > MAINTAINERS file with this patch. However, they will not be
> > deleted from QEMU Hall of Fame, where their names will always
> > be carved in stone as QEMU pioneers and granddadies.
> >
> > Acked-by: Aurelien Jarno <aurelien@aurel32.net>
> > Acked-by: Magnus Damm <magnus.damm@gmail.com>
> > Acked-by: Yoshinori Sato <ysato@users.sourceforge.jp>
>
> They more or less "acked" Philippe's patch, but I don't think you can
> conclude from that that they agree to your changes automatically, too.
> So please don't put "Acked-by"s into your completely new patch that you
> did not gather yourself.
>

I disagree. I carefully studied their responses and they, as a rule, acked-by
the general approach, not a particular patch. I will keep Acked-by:s unless
some of them objects.

> > Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
> > ---
> >  MAINTAINERS | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 6e7890ce82..7ddb6db38c 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -296,7 +296,7 @@ F: tests/tcg/s390x/
> >  L: qemu-s390x@nongnu.org
> >
> >  SH4 TCG CPUs
> > -M: Aurelien Jarno <aurelien@aurel32.net>
> > +M: Yoshinori Sato <ysato@users.sourceforge.jp>
> >  S: Odd Fixes
> >  F: target/sh4/
> >  F: hw/sh4/
> > @@ -1251,14 +1251,14 @@ F: include/hw/riscv/opentitan.h
> >  SH4 Machines
> >  ------------
> >  R2D
> > -M: Magnus Damm <magnus.damm@gmail.com>
> > +M: Yoshinori Sato <ysato@users.sourceforge.jp>
> >  S: Maintained
> >  F: hw/sh4/r2d.c
> >  F: hw/intc/sh_intc.c
> >  F: hw/timer/sh_timer.c
>
> Magnus said that he is still interested in R2D, just does not have the
> time anymore to actively maintain it. So I think it is a bad idea if you
> completely remove him here. His line should be changed from "M:" to "R:"
> instead unless he explicitely states that he wants to completely be removed.
>

Fair enough. I will mention him as R: in the next version.

Thanks,
Aleksandar

>  Thomas
>