[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/6] iotests: 194: wait migration completion on target to
From: |
Alex Bennée |
Subject: |
Re: [PATCH v2 1/6] iotests: 194: wait migration completion on target too |
Date: |
Wed, 10 Jun 2020 17:38:30 +0100 |
User-agent: |
mu4e 1.5.2; emacs 28.0.50 |
Alex Bennée <alex.bennee@linaro.org> writes:
> From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>
> It is possible, that shutdown on target occurs earlier than migration
> finish. In this case we crash in bdrv_release_dirty_bitmap_locked()
> on assertion "assert(!bdrv_dirty_bitmap_busy(bitmap));" as we do have
> busy bitmap, as bitmap migration is ongoing.
>
> We'll fix bitmap migration to gracefully cancel on early shutdown soon.
> Now let's fix iotest 194 to wait migration completion before shutdown.
>
> Note that in this test dest_vm.shutdown() is called implicitly, as vms
> used as context-providers, see __exit__() method of QEMUMachine class.
>
> Actually, not waiting migration finish is a wrong thing, but the test
> started to crash after commit ae00aa239847682
> "iotests: 194: test also migration of dirty bitmap", which added dirty
> bitmaps here. So, Fixes: tag won't hurt.
>
> Fixes: ae00aa2398476824f0eca80461da215e7cdc1c3b
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> Tested-by: Thomas Huth <thuth@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Message-Id: <20200604083341.26978-1-vsementsov@virtuozzo.com>
Obviously this patch isn't going in via plugins/next - I had it in my
tree to keep CI green and forgot to take that into account when
generating the series!
--
Alex Bennée
- [PATCH v2 0/6] plugins/next (lockstep, api, hwprofile), Alex Bennée, 2020/06/10
- [PATCH v2 3/6] cputlb: ensure we save the IOTLB data in case of reset, Alex Bennée, 2020/06/10
- [PATCH v2 1/6] iotests: 194: wait migration completion on target too, Alex Bennée, 2020/06/10
- Re: [PATCH v2 1/6] iotests: 194: wait migration completion on target too,
Alex Bennée <=
- [PATCH v2 4/6] hw/virtio/pci: include vdev name in registered PCI sections, Alex Bennée, 2020/06/10
- [PATCH v2 2/6] plugins: new lockstep plugin for debugging TCG changes, Alex Bennée, 2020/06/10
- [PATCH v2 5/6] plugins: add API to return a name for a IO device, Alex Bennée, 2020/06/10
- [PATCH v2 6/6] plugins: new hwprofile plugin, Alex Bennée, 2020/06/10