[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH RESEND v3 46/58] qdev: Drop qdev_realize() support for null bus
From: |
Markus Armbruster |
Subject: |
[PATCH RESEND v3 46/58] qdev: Drop qdev_realize() support for null bus |
Date: |
Wed, 10 Jun 2020 07:32:35 +0200 |
The "null @bus means main system bus" convenience feature is no longer
used. Drop it.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/core/qdev.c | 16 ++--------------
1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index a1fdebb3aa..78a06db76e 100644
--- a/hw/core/qdev.c
+++ b/hw/core/qdev.c
@@ -408,8 +408,7 @@ void qdev_init_nofail(DeviceState *dev)
/*
* Realize @dev.
* @dev must not be plugged into a bus.
- * Plug @dev into @bus if non-null, else into the main system bus.
- * This takes a reference to @dev.
+ * Plug @dev into @bus. This takes a reference to @dev.
* If @dev has no QOM parent, make one up, taking another reference.
* On success, return true.
* On failure, store an error through @errp and return false.
@@ -419,18 +418,7 @@ bool qdev_realize(DeviceState *dev, BusState *bus, Error
**errp)
Error *err = NULL;
assert(!dev->realized && !dev->parent_bus);
-
- if (!bus) {
- /*
- * Assert that the device really is a SysBusDevice before we
- * put it onto the sysbus. Non-sysbus devices which aren't
- * being put onto a bus should be realized with
- * object_property_set_bool(OBJECT(dev), true, "realized",
- * errp);
- */
- g_assert(object_dynamic_cast(OBJECT(dev), TYPE_SYS_BUS_DEVICE));
- bus = sysbus_get_default();
- }
+ assert(bus);
qdev_set_parent_bus(dev, bus);
--
2.26.2
- [PATCH RESEND v3 30/58] qdev: qdev_create(), qdev_try_create() are now unused, drop, (continued)
- [PATCH RESEND v3 30/58] qdev: qdev_create(), qdev_try_create() are now unused, drop, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 22/58] ssi: ssi_auto_connect_slaves() never does anything, drop, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 09/58] qdev: Convert uses of qdev_create() with Coccinelle, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 26/58] usb: New usb_new(), usb_realize_and_unref(), Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 24/58] ssi: Convert last use of ssi_create_slave_no_init() manually, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 29/58] usb: Eliminate usb_try_create_simple(), Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 21/58] isa: isa_create(), isa_try_create() are now unused, drop, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 32/58] auxbus: New aux_bus_realize(), pairing with aux_bus_init(), Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 33/58] auxbus: Convert a use of qdev_set_parent_bus(), Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 17/58] pci: pci_create(), pci_create_multifunction() are now unused, drop, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 46/58] qdev: Drop qdev_realize() support for null bus,
Markus Armbruster <=
- [PATCH RESEND v3 13/58] pci: New pci_new(), pci_realize_and_unref() etc., Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 42/58] hw/arm/armsse: Pass correct child size to sysbus_init_child_obj(), Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 25/58] ssi: ssi_create_slave_no_init() is now unused, drop, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 15/58] pci: Convert uses of pci_create() etc. with Coccinelle, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 44/58] sysbus: New sysbus_realize(), sysbus_realize_and_unref(), Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 37/58] macio: Convert use of qdev_set_parent_bus(), Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 40/58] microbit: Tidy up sysbus_init_child_obj() @child argument, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 39/58] sysbus: Drop useless OBJECT() in sysbus_init_child_obj() calls, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 41/58] sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 1, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 43/58] sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 2, Markus Armbruster, 2020/06/10