[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 19/56] tests: tpm-emu: Remove assert on TPM2_ST_NO_SESSIONS
From: |
Michael S. Tsirkin |
Subject: |
[PULL 19/56] tests: tpm-emu: Remove assert on TPM2_ST_NO_SESSIONS |
Date: |
Wed, 10 Jun 2020 00:27:15 -0400 |
From: Eric Auger <eric.auger@redhat.com>
bios-tables-test executes SeaBIOS. Indeed FW is needed to
fetch tables from QEMU and put them into the guest RAM. Also
the FW patches cross table pointers. At some point, SeaBIOS
ends up calling the TPM2_CC_HierarchyControl command with
TPM2_ST_SESSIONS tag, most probably steming from
tpm_set_failure/tpm20_hierarchycontrol SeaBIOS call path.
This causes an assert() in the qtest tpm emulation code.
As the goal here is not to boot SeaBIOS completely but just
let it grab the ACPI tables and consolidate them, let's just
remove the assert().
Signed-off-by: Eric Auger <eric.auger@redhat.com>
Message-Id: <20200609125409.24179-4-eric.auger@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
tests/qtest/tpm-emu.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/qtest/tpm-emu.c b/tests/qtest/tpm-emu.c
index c43ac4aef8..298d0eec74 100644
--- a/tests/qtest/tpm-emu.c
+++ b/tests/qtest/tpm-emu.c
@@ -49,7 +49,6 @@ static void *tpm_emu_tpm_thread(void *data)
s->tpm_msg->tag = be16_to_cpu(s->tpm_msg->tag);
s->tpm_msg->len = be32_to_cpu(s->tpm_msg->len);
g_assert_cmpint(s->tpm_msg->len, >=, minhlen);
- g_assert_cmpint(s->tpm_msg->tag, ==, TPM2_ST_NO_SESSIONS);
s->tpm_msg = g_realloc(s->tpm_msg, s->tpm_msg->len);
qio_channel_read(ioc, (char *)&s->tpm_msg->code,
--
MST
- [PULL 08/56] acpi: serial: don't use _STA method, (continued)
- [PULL 08/56] acpi: serial: don't use _STA method, Michael S. Tsirkin, 2020/06/10
- [PULL 09/56] acpi: move aml builder code for serial device, Michael S. Tsirkin, 2020/06/10
- [PULL 10/56] acpi: parallel: don't use _STA method, Michael S. Tsirkin, 2020/06/10
- [PULL 12/56] tests/acpi: update DSDT expected files, Michael S. Tsirkin, 2020/06/10
- [PULL 13/56] acpi: tpm: Do not build TCPA table for TPM 2, Michael S. Tsirkin, 2020/06/10
- [PULL 14/56] acpi: Convert build_tpm2() to build_append* API, Michael S. Tsirkin, 2020/06/10
- [PULL 15/56] acpi: Move build_tpm2() in the generic part, Michael S. Tsirkin, 2020/06/10
- [PULL 16/56] arm/acpi: TPM2 ACPI table support, Michael S. Tsirkin, 2020/06/10
- [PULL 17/56] test/tpm-emu: include sockets and channel headers in tpm-emu header, Michael S. Tsirkin, 2020/06/10
- [PULL 18/56] tests/acpi: Add void tables for Q35/TPM-TIS bios-tables-test, Michael S. Tsirkin, 2020/06/10
- [PULL 19/56] tests: tpm-emu: Remove assert on TPM2_ST_NO_SESSIONS,
Michael S. Tsirkin <=
- [PULL 20/56] bios-tables-test: Add Q35/TPM-TIS test, Michael S. Tsirkin, 2020/06/10
- [PULL 22/56] virtio-balloon: fix free page hinting without an iothread, Michael S. Tsirkin, 2020/06/10
- [PULL 21/56] bios-tables-test: Generate reference tables for Q35/TPM-TIS, Michael S. Tsirkin, 2020/06/10
- [PULL 23/56] virtio-balloon: fix free page hinting check on unrealize, Michael S. Tsirkin, 2020/06/10
- [PULL 25/56] virtio-balloon: Implement support for page poison reporting feature, Michael S. Tsirkin, 2020/06/10
- [PULL 24/56] virtio-balloon: unref the iothread when unrealizing, Michael S. Tsirkin, 2020/06/10
- [PULL 27/56] MAINTAINERS: Fix the classification of bios-tables-test-allowed-diff.h, Michael S. Tsirkin, 2020/06/10
- [PULL 28/56] hw/pci/pcie: Move hot plug capability check to pre_plug callback, Michael S. Tsirkin, 2020/06/10
- [PULL 29/56] pci: assert configuration access is within bounds, Michael S. Tsirkin, 2020/06/10
- [PULL 31/56] hw/pci/pci_bridge: Correct pci_bridge_io memory region size, Michael S. Tsirkin, 2020/06/10