[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 07/56] acpi: rtc: use a single crs range
From: |
Michael S. Tsirkin |
Subject: |
[PULL 07/56] acpi: rtc: use a single crs range |
Date: |
Wed, 10 Jun 2020 00:26:47 -0400 |
From: Gerd Hoffmann <kraxel@redhat.com>
Use a single io range for _CRS instead of two,
following what real hardware does.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Message-Id: <20200515150421.25479-4-kraxel@redhat.com>
---
hw/rtc/mc146818rtc.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/hw/rtc/mc146818rtc.c b/hw/rtc/mc146818rtc.c
index fe05a4488e..1e9fa0f33f 100644
--- a/hw/rtc/mc146818rtc.c
+++ b/hw/rtc/mc146818rtc.c
@@ -1013,12 +1013,14 @@ static void rtc_build_aml(ISADevice *isadev, Aml *scope)
Aml *dev;
Aml *crs;
+ /*
+ * Reserving 8 io ports here, following what physical hardware
+ * does, even though qemu only responds to the first two ports.
+ */
crs = aml_resource_template();
aml_append(crs, aml_io(AML_DECODE16, RTC_ISA_BASE, RTC_ISA_BASE,
- 0x10, 0x02));
+ 0x01, 0x08));
aml_append(crs, aml_irq_no_flags(RTC_ISA_IRQ));
- aml_append(crs, aml_io(AML_DECODE16, RTC_ISA_BASE + 2, RTC_ISA_BASE + 2,
- 0x02, 0x06));
dev = aml_device("RTC");
aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0B00")));
--
MST
- [PULL 00/56] virtio,acpi,pci: features, fixes, cleanups, tests, Michael S. Tsirkin, 2020/06/10
- [PULL 02/56] diffs-allowed: add the SRAT AML to diffs-allowed, Michael S. Tsirkin, 2020/06/10
- [PULL 01/56] msix: allow qword MSI-X table accesses, Michael S. Tsirkin, 2020/06/10
- [PULL 06/56] acpi: move aml builder code for rtc device, Michael S. Tsirkin, 2020/06/10
- [PULL 07/56] acpi: rtc: use a single crs range,
Michael S. Tsirkin <=
- [PULL 08/56] acpi: serial: don't use _STA method, Michael S. Tsirkin, 2020/06/10
- [PULL 09/56] acpi: move aml builder code for serial device, Michael S. Tsirkin, 2020/06/10
- [PULL 10/56] acpi: parallel: don't use _STA method, Michael S. Tsirkin, 2020/06/10
- [PULL 12/56] tests/acpi: update DSDT expected files, Michael S. Tsirkin, 2020/06/10
- [PULL 13/56] acpi: tpm: Do not build TCPA table for TPM 2, Michael S. Tsirkin, 2020/06/10
- [PULL 14/56] acpi: Convert build_tpm2() to build_append* API, Michael S. Tsirkin, 2020/06/10
- [PULL 15/56] acpi: Move build_tpm2() in the generic part, Michael S. Tsirkin, 2020/06/10
- [PULL 16/56] arm/acpi: TPM2 ACPI table support, Michael S. Tsirkin, 2020/06/10
- [PULL 17/56] test/tpm-emu: include sockets and channel headers in tpm-emu header, Michael S. Tsirkin, 2020/06/10
- [PULL 18/56] tests/acpi: Add void tables for Q35/TPM-TIS bios-tables-test, Michael S. Tsirkin, 2020/06/10