[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] pci: Display PCI IRQ pin in "info pci"
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] pci: Display PCI IRQ pin in "info pci" |
|
Date: |
Tue, 9 Jun 2020 18:18:15 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 6/9/20 6:13 PM, Peter Xu wrote:
> On Tue, Jun 09, 2020 at 11:49:49AM -0400, Michael S. Tsirkin wrote:
>>>>>> @@ -417,8 +419,8 @@
>>>>>> { 'struct': 'PciDeviceInfo',
>>>>>> 'data': {'bus': 'int', 'slot': 'int', 'function': 'int',
>>>>>> 'class_info': 'PciDeviceClass', 'id': 'PciDeviceId',
>>>>>> - '*irq': 'int', 'qdev_id': 'str', '*pci_bridge':
>>>>>> 'PciBridgeInfo',
>>>>>> - 'regions': ['PciMemoryRegion']} }
>>>>>> + '*irq': 'int', 'irq_pin': 'int', 'qdev_id': 'str',
>>>>>> + '*pci_bridge': 'PciBridgeInfo', 'regions':
>>>>>> ['PciMemoryRegion'] }}
>>>>>
>>>>> and the pre-existing pci_bridge is indeed the consistency issue.
>>>>
>>>> Yeh, actually every key in this struct. :)
>>>
>>> Using 'irq-pin':
>>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>
>>
>> Peter can you fix and repost pls?
>
> I still think irq_pin is better because as I mentioned previously all the
> existing keys are using underscores... Phil?
No problem!