Re: [PATCH v1] pc: Support coldplugging of virtio-pmem-pci devices on all buses

[David Hildenbrand]

On 09.06.20 17:47, Michael S. Tsirkin wrote:
> On Mon, May 25, 2020 at 10:45:11AM +0200, David Hildenbrand wrote:
>> E.g., with "pc-q35-4.2", trying to coldplug a virtio-pmem-pci devices
>> results in
>>     "virtio-pmem-pci not supported on this bus"
>>
>> Reasons is, that the bus does not support hotplug and, therefore, does
>> not have a hotplug handler. Let's allow coldplugging virtio-pmem devices
>> on such buses. The hotplug order is only relevant for virtio-pmem-pci
>> when the guest is already alive and the device is visible before
>> memory_device_plug() wired up the memory device bits.
>>
>> Hotplug attempts will still fail with:
>>     "Error: Bus 'pcie.0' does not support hotplugging"
>>
>> Hotunplug attempts will still fail with:
>>     "Error: Bus 'pcie.0' does not support hotplugging"
>>
>> Reported-by: Vivek Goyal <vgoyal@redhat.com>
>> Cc: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
>> Cc: Igor Mammedov <imammedo@redhat.com>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> Cc: Richard Henderson <rth@twiddle.net>
>> Cc: Eduardo Habkost <ehabkost@redhat.com>
>> Cc: "Michael S. Tsirkin" <mst@redhat.com>
>> Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
>> Signed-off-by: David Hildenbrand <david@redhat.com>
> 
> I assume you are still debugging Vivek's issues, right?
> Let me know when you feel it's time to merge this ...

The remain issue is lack of libvirt support. This is good to be merged
from my point of view.

Thanks!


-- 
Thanks,

David / dhildenb