[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/1] hw/block/nvme: fix assert on invalid irq vector
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 0/1] hw/block/nvme: fix assert on invalid irq vector |
Date: |
Tue, 9 Jun 2020 13:17:04 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 6/9/20 11:45 AM, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> I goofed up with commit c09794fe40e3 ("hw/block/nvme: allow use of any
> valid msix vector").
Kevin, since your queue isn't merged, can you directly squash the fix?
>
> This fixes the goof by adding a new msix_qsize parameter. As a nice
> side-effect this allows a device with less interrupt vectors available
> than supported queues. Also, improve the error handling in
> nvme_init_pci().
>
> Kevin, please consider picking this up for the block branch when
> reviewed.
>
> Cc: qemu-devel@nongnu.org
> Cc: Keith Busch <kbusch@kernel.org>
> Cc: Max Reitz <mreitz@redhat.com>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Klaus Jensen <its@irrelevant.dk>
> Cc: Javier Gonzalez <javier.gonz@samsung.com>
> Cc: Maxim Levitsky <mlevitsk@redhat.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> Klaus Jensen (2):
> hw/block/nvme: add msix_qsize parameter
> hw/block/nvme: verify msix_init_exclusive_bar() return value
>
> hw/block/nvme.c | 28 ++++++++++++++++++++++------
> hw/block/nvme.h | 1 +
> 2 files changed, 23 insertions(+), 6 deletions(-)
>