Re: [PATCH v5 13/13] qcow2_format.py: dump bitmaps header extension

[Vladimir Sementsov-Ogievskiy]

09.06.2020 01:00, Eric Blake wrote:
> On 6/6/20 3:18 AM, Vladimir Sementsov-Ogievskiy wrote:
> > Add class for bitmap extension and dump its fields. Further work is to
> > dump bitmap directory.
> >
> > Test new functionality inside 291 iotest.
> >
> > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> > Reviewed-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
> > ---
>
> > @@ -88,6 +90,8 @@ $QEMU_IMG bitmap --merge tmp -f $IMGFMT "$TEST_IMG" b0
> >   $QEMU_IMG bitmap --remove --image-opts \
> >       driver=$IMGFMT,file.driver=file,file.filename="$TEST_IMG" tmp
> >   $QEMU_IMG info "$TEST_IMG" | _filter_img_info --format-specific
> > +echo "Check resulting qcow2 header extensions:"
> > +$PYTHON qcow2.py "$TEST_IMG" dump-header-exts
>
> Context conflict with my pending patch to resolve an issue reported by Kevin:
>
> https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg02057.html
>
> but that is easy enough to resolve.
>
> I'll be queuing this series through my bitmaps tree, hopefully with a pull 
> request on Tuesday.

Great! Thanks!

--
Best regards,
Vladimir