Re: [PATCH v2 0/6] Add strace support for printing arguments of selected syscalls

[no-reply]

Patchew URL: 
20200608164357.25065-1-filip.bozuta@syrmia.com/">https://patchew.org/QEMU/20200608164357.25065-1-filip.bozuta@syrmia.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20200608164357.25065-1-filip.bozuta@syrmia.com
Subject: [PATCH v2 0/6] Add strace support for printing arguments of selected 
syscalls
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
dc47702 linux-user: Add strace support for printing arguments of fallocate()
8478ea8 linux-user: Add strace support for printing arguments of 
chown()/lchown()
f287b7f linux-user: Add strace support for printing arguments of lseek()
615a5d8 linux-user: Add strace support for printing argument of syscalls used 
for extended attributes
b0acbe9 linux-user: Add strace support for a group of syscalls
3370ce2 linux-user: Extend strace support to enable argument printing after 
syscall execution

=== OUTPUT BEGIN ===
1/6 Checking commit 3370ce28f836 (linux-user: Extend strace support to enable 
argument printing after syscall execution)
2/6 Checking commit b0acbe9ef27d (linux-user: Add strace support for a group of 
syscalls)
3/6 Checking commit 615a5d8e9d21 (linux-user: Add strace support for printing 
argument of syscalls used for extended attributes)
4/6 Checking commit f287b7f80630 (linux-user: Add strace support for printing 
arguments of lseek())
5/6 Checking commit 8478ea817695 (linux-user: Add strace support for printing 
arguments of chown()/lchown())
6/6 Checking commit dc477027df64 (linux-user: Add strace support for printing 
arguments of fallocate())
ERROR: storage class should be at the beginning of the declaration
#69: FILE: linux-user/strace.c:1147:
+UNUSED static struct flags falloc_flags[] = {

total: 1 errors, 0 warnings, 104 lines checked

Patch 6/6 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20200608164357.25065-1-filip.bozuta@syrmia.com/testing.checkpatch/?type=message">http://patchew.org/logs/20200608164357.25065-1-filip.bozuta@syrmia.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com