Re: [PATCH v1] hmp: Make json format optional for qom-set

[David Hildenbrand]

> Am 08.06.2020 um 16:16 schrieb Paolo Bonzini <pbonzini@redhat.com>:
> 
> On 08/06/20 16:06, David Hildenbrand wrote:
>>     {
>>         .name       = "qom-set",
>> -        .args_type  = "path:s,property:s,value:S",
>> -        .params     = "path property value",
>> -        .help       = "set QOM property",
>> +        .args_type  = "json:-j,path:s,property:s,value:s",
> 
> I think this should remain an uppercase "S", so that it grabs the rest
> of the input rather than stop at the first space.
> 

Yes, changed by mistake (while working on a revert). Thanks!

> Paolo
> 
>> +        .params     = "[-j] path property value",
>> +        .help       = "set QOM property.\n\t\t\t"
>> +                      "-j: the property is specified in json format.",
>>         .cmd        = hmp_qom_set,
>>         .flags      = "p",
>>     },
>> diff --git a/qom/qom-hmp-cmds.c b/qom/qom-hmp-cmds.c
>