Re: [PATCH 0/7] hw/misc/empty_slot: Spring cleaning

[Artyom Tarasenko]

On Sun, May 24, 2020 at 10:21 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> On 5/24/20 9:37 PM, Aleksandar Markovic wrote:
> > нед, 24. мај 2020. у 18:58 Philippe Mathieu-Daudé <philmd@redhat.com>
> > је написао/ла:
> >>
> >> ping?
> >>
> >
> > I agree with all of your patches, they absolutely make sense to me,
> > but I would like to know Peter's opinion on such treatment of empty
> > slots.
> >
> > I am going to give r-bs and integrate mips patches as soon as Peter
> > OKs the general approach. So, Peter, is Philippe's approach to empty
> > slots fine?
>
> Thanks Aleksandar for looking at this series.
>
> I expect a neutral opinion from Peter.
>
> What would be helpful is feedback from Artyom, since it authored this
> device.
>
> Artyom, do you mind Acking the series?

Thanks for asking and sorry for the delay. My mailer played a bad trick on me.
The patches definitely make sense:

Acked-by: Artyom Tarasenko <atar4qemu@gmail.com>



> Thanks,
>
> Phil.
>
> >
> > Aleksandar
> >
> >> On 5/10/20 5:28 PM, Philippe Mathieu-Daudé wrote:
> >>> New Spring, new opportunity to clean this device :)
> >>> (v1 was in 2018, v2 in 2019).
> >>>
> >>> - lower device priority
> >>> - follow qdev model and use properties
> >>> - convert to trace events
> >>> - describe with slot name
> >>> - move under hw/misc/ and cover in MAINTAINERS
> >>>
> >>> Peter, I hope you are OK adding it wit UNIMP device,
> >>> as both are very similar, and don't have much activity.
> >>>
> >>> Only MIPS/SPARC32 targets use this device.
> >>>
> >>> v2: https://www.mail-archive.com/qemu-devel@nongnu.org/msg626498.html
> >>> v1: https://www.mail-archive.com/qemu-devel@nongnu.org/msg564060.html
> >>>
> >>> Philippe Mathieu-Daudé (7):
> >>>   hw/sparc/sun4m: Use UnimplementedDevice for I/O devices
> >>>   hw/misc/empty_slot: Lower address space priority
> >>>   hw/misc/empty_slot: Convert 'size' field as qdev property
> >>>   hw/misc/empty_slot: Add a 'name' qdev property
> >>>   hw/misc/empty_slot: Convert debug printf() to trace event
> >>>   hw/misc/empty_slot: Move the 'hw/misc' and cover in MAINTAINERS
> >>>   hw/misc/empty_slot: Name the slots when created
> >>>
> >>>  include/hw/empty_slot.h        |  9 -------
> >>>  include/hw/misc/empty_slot.h   | 19 ++++++++++++++
> >>>  hw/mips/mips_malta.c           |  4 +--
> >>>  hw/{core => misc}/empty_slot.c | 47 +++++++++++++++++++---------------
> >>>  hw/sparc/sun4m.c               | 23 +++++++++++------
> >>>  MAINTAINERS                    |  4 ++-
> >>>  hw/core/Makefile.objs          |  1 -
> >>>  hw/misc/Makefile.objs          |  1 +
> >>>  hw/misc/trace-events           |  4 +++
> >>>  9 files changed, 70 insertions(+), 42 deletions(-)
> >>>  delete mode 100644 include/hw/empty_slot.h
> >>>  create mode 100644 include/hw/misc/empty_slot.h
> >>>  rename hw/{core => misc}/empty_slot.c (66%)
> >>>
> >>
> >
>


--
Regards,
Artyom Tarasenko

SPARC and PPC PReP under qemu blog: http://tyom.blogspot.com/search/label/qemu