Re: [PATCH v4 2/3] hw/acpi/nvdimm: add a helper to augment SRAT generation

[Verma, Vishal L]

On Fri, 2020-06-05 at 10:23 +0200, Igor Mammedov wrote:

> > > > The relevant command line options to exercise this are below. Nodes 0-1
> > > > contain CPUs and regular memory, and nodes 2-3 are the NVDIMM address
> > > > space.
> > > > 
> > > >   -numa node,nodeid=0,mem=2048M,
> > > >   -numa node,nodeid=1,mem=2048M,  
> > > 
> > > pls note that 'mem' is about to be disabled for new machine types in 
> > > favor of memdev
> > > so this CLI won't work.
> > > It would be nice to update commit message with memdev variant of CLI  
> > 
> > I saw the warnings printed - I did try to use memdevs, but it didn't
> > quite work with my use case. I'm supplying mem=0 for the pmem/nvdimm
> > devices that I want to give a specific numa node, but not give them any
> > more regular memory aside from the nvdimm itself (see nodes 4 and 5
> > below). And for some reason I couldn't do that with memdevs.
> it should work since 4.1
> 
> here is example 
> qemu-system-x86_64 -object memory-backend-ram,id=mem0,size=1G -m 1G \
>  -numa node,memdev=mem0 -numa node -monitor stdio
> 
> QEMU 5.0.50 monitor - type 'help' for more information
> (qemu) VNC server running on ::1:5900
> info numa
> 2 nodes
> node 0 cpus: 0
> node 0 size: 1024 MB
> node 0 plugged: 0 MB
> node 1 cpus:
> node 1 size: 0 MB
> node 1 plugged: 0 MB
> (qemu)
> 

Perfect got it working, Thanks Igor!

I'll send a v5 with the updated commit message and add your reviewed-by.

-Vishal