[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 06/11] Makefile: Remove dangerous EOL trailing backslash
From: |
Richard Henderson |
Subject: |
Re: [PATCH v7 06/11] Makefile: Remove dangerous EOL trailing backslash |
Date: |
Fri, 5 Jun 2020 14:52:21 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 6/5/20 10:58 AM, Philippe Mathieu-Daudé wrote:
> One might get caught trying to understand unexpected Makefile
> behavior. Trailing backslash can help to split very long lines,
> but are rather dangerous when nothing follow. Preserve other
> developers debugging time by removing this one.
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
- [PATCH v7 00/11] accel: Allow targets to use Kconfig, Philippe Mathieu-Daudé, 2020/06/05
- [PATCH v7 01/11] MAINTAINERS: Fix KVM path expansion glob, Philippe Mathieu-Daudé, 2020/06/05
- [PATCH v7 02/11] MAINTAINERS: Add an 'overall' entry for accelerators, Philippe Mathieu-Daudé, 2020/06/05
- [PATCH v7 04/11] rules.mak: Add strequal() and startswith() rules, Philippe Mathieu-Daudé, 2020/06/05
- [PATCH v7 05/11] rules.mak: Add base-arch() rule, Philippe Mathieu-Daudé, 2020/06/05
- [PATCH v7 03/11] MAINTAINERS: Add an entry for the HAX accelerator, Philippe Mathieu-Daudé, 2020/06/05
- [PATCH v7 06/11] Makefile: Remove dangerous EOL trailing backslash, Philippe Mathieu-Daudé, 2020/06/05
- Re: [PATCH v7 06/11] Makefile: Remove dangerous EOL trailing backslash,
Richard Henderson <=
- [PATCH v7 07/11] Makefile: Write MINIKCONF variables as one entry per line, Philippe Mathieu-Daudé, 2020/06/05
- [PATCH v7 08/11] accel/Kconfig: Extract accel selectors into their own config, Philippe Mathieu-Daudé, 2020/06/05
- [PATCH v7 09/11] accel/Kconfig: Add the TCG selector, Philippe Mathieu-Daudé, 2020/06/05
- [PATCH v7 10/11] Makefile: Allow target-specific optional Kconfig, Philippe Mathieu-Daudé, 2020/06/05
- [PATCH v7 11/11] accel/tcg: Add stub for probe_access(), Philippe Mathieu-Daudé, 2020/06/05