Re: [PATCH v4 01/12] qcow2.py: python style fixes

[Eric Blake]

On 6/4/20 12:41 PM, Vladimir Sementsov-Ogievskiy wrote:
> Fix flake8 complains. Leave the only chunk of lines over 79 characters:

complaints

> initialization of cmds variable. Leave it for another day, when it
> should be refactored to utilize argparse instead of hand-written
> parsing.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>   tests/qemu-iotests/qcow2.py | 92 +++++++++++++++++++++----------------
>   1 file changed, 53 insertions(+), 39 deletions(-)

>   cmds = [
> -    [ 'dump-header',          cmd_dump_header,          0, 'Dump image header 
> and header extensions' ],
> -    [ 'dump-header-exts',     cmd_dump_header_exts,     0, 'Dump image header 
> extensions' ],
> -    [ 'set-header',           cmd_set_header,           2, 'Set a field in the 
> header'],
> -    [ 'add-header-ext',       cmd_add_header_ext,       2, 'Add a header 
> extension' ],
> -    [ 'add-header-ext-stdio', cmd_add_header_ext_stdio, 1, 'Add a header 
> extension, data from stdin' ],
> -    [ 'del-header-ext',       cmd_del_header_ext,       1, 'Delete a header 
> extension' ],
> -    [ 'set-feature-bit',      cmd_set_feature_bit,      2, 'Set a feature 
> bit'],
> +    ['dump-header',          cmd_dump_header,          0, 'Dump image header 
> and header extensions'],

I know you mentioned argparse as a later refactoring, but is it worth 
reflowing the table in the meantime?

['dump-header', cmd_dump_header, 0,
 'Dump image header and header extensions'],
[...
 '...'],

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org