[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] fuzz: add oss-fuzz build.sh script
From: |
Darren Kenny |
Subject: |
Re: [PATCH v2] fuzz: add oss-fuzz build.sh script |
Date: |
Fri, 05 Jun 2020 19:58:51 +0100 |
On Friday, 2020-06-05 at 14:24:59 -04, Alexander Bulekov wrote:
> Hi Darren,
>
> On 200605 1858, Darren Kenny wrote:
>> Hi Alex,
>>
>> From looking at another OSS Fuzz project recently (a coincidence) I
>> wonder if we could make this script work so that it can be run outside
>> of the OSS-Fuzz environment?
>>
>> Specifically, for example, if $OUT is not set, then creating a subdir in
>> the build directory, and setting it to be that.
>>
> For $OUT, do you think it would be better to require it as
> a user-configurable environment variable? My concern is that making it
> a subdirectory of the build dir would mean that the pc-bios files exist
> located in $OUT/../pc-bios. This doesn't reflect OSS-Fuzz, where we
> specifically have to copy them to $OUT/pc-bios/
>
The script is copying them in to $OUT near the end still, isn't it?
That should be fine if it is, shouldn't it? Or am I missing something?
Thanks,
Darren.