[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 0/3] python/machine.py: refactor shutdown
|
From: |
Kevin Wolf |
|
Subject: |
Re: [PATCH v3 0/3] python/machine.py: refactor shutdown |
|
Date: |
Fri, 5 Jun 2020 11:34:53 +0200 |
Am 04.06.2020 um 21:52 hat John Snow geschrieben:
> v3:
> - Split _post_shutdown refactor into own patch (now 1/3)
Feels much easier to read now!
> - Re-add sigkill warning squelch (now 3/3)
>
> NOTE: I re-added the squelch in its own patch for review purposes, but
> for the purposes of avoiding temporary breakage, a maintainer may wish
> to squash patches 2 and 3 if they are accepted.
As I found in the v2 review that we don't even have a single user of
hard=True, I don't think it matters. A separate patch makes things
easier to understand, so I would leave it as you have it in this series.
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
- [PATCH v3 0/3] python/machine.py: refactor shutdown, John Snow, 2020/06/04
- [PATCH v3 1/3] python/machine.py: consolidate _post_shutdown(), John Snow, 2020/06/04
- [PATCH v3 2/3] python/machine.py: refactor shutdown, John Snow, 2020/06/04
- [PATCH v3 3/3] python/machine.py: re-add sigkill warning suppression, John Snow, 2020/06/04
- Re: [PATCH v3 0/3] python/machine.py: refactor shutdown,
Kevin Wolf <=
- Re: [PATCH v3 0/3] python/machine.py: refactor shutdown, Philippe Mathieu-Daudé, 2020/06/09
- Re: [PATCH v3 0/3] python/machine.py: refactor shutdown, Cleber Rosa, 2020/06/16
- Re: [PATCH v3 0/3] python/machine.py: refactor shutdown, Philippe Mathieu-Daudé, 2020/06/17
- Re: [PATCH v3 0/3] python/machine.py: refactor shutdown, Philippe Mathieu-Daudé, 2020/06/20
- Re: [PATCH v3 0/3] python/machine.py: refactor shutdown, John Snow, 2020/06/22