[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 11/11] accel/tcg: Add stub for probe_access()
From: |
David Hildenbrand |
Subject: |
Re: [PATCH v5 11/11] accel/tcg: Add stub for probe_access() |
Date: |
Fri, 5 Jun 2020 09:45:14 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 05.06.20 09:39, Philippe Mathieu-Daudé wrote:
> From: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> The TCG helpers where added in b92e5a22ec3 in softmmu_template.h.
> probe_write() was added in there in 3b4afc9e75a to be moved out
> to accel/tcg/cputlb.c in 3b08f0a9254, and was later refactored
> as probe_access() in c25c283df0f.
> Since it is a TCG specific helper, add a stub to avoid failures
> when building without TCG, such:
>
> target/arm/helper.o: In function `probe_read':
> include/exec/exec-all.h:362: undefined reference to `probe_access'
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: Emilio G. Cota <cota@braap.org>
> Cc: Alex Bennée <alex.bennee@linaro.org>
> Cc: David Hildenbrand <david@redhat.com>
> ---
> accel/stubs/tcg-stub.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/accel/stubs/tcg-stub.c b/accel/stubs/tcg-stub.c
> index 677191a69c..e4bbf997aa 100644
> --- a/accel/stubs/tcg-stub.c
> +++ b/accel/stubs/tcg-stub.c
> @@ -22,3 +22,10 @@ void tb_flush(CPUState *cpu)
> void tlb_set_dirty(CPUState *cpu, target_ulong vaddr)
> {
> }
> +
> +void *probe_access(CPUArchState *env, target_ulong addr, int size,
> + MMUAccessType access_type, int mmu_idx, uintptr_t retaddr)
> +{
> + /* Handled by hardware accelerator. */
> + g_assert_not_reached();
> +}
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
- Re: [PATCH v5 04/11] rules.mak: Add strequal() and startwith() and rules, (continued)
- [PATCH v5 05/11] rules.mak: Add base-arch() rule, Philippe Mathieu-Daudé, 2020/06/05
- [PATCH v5 06/11] Makefile: Remove dangerous EOL trailing backslash, Philippe Mathieu-Daudé, 2020/06/05
- [PATCH v5 03/11] MAINTAINERS: Add an entry for the HAX accelerator, Philippe Mathieu-Daudé, 2020/06/05
- [PATCH v5 07/11] Makefile: Write MINIKCONF variables as one entry per line, Philippe Mathieu-Daudé, 2020/06/05
- [PATCH v5 08/11] accel/Kconfig: Extract accel selectors into their own config, Philippe Mathieu-Daudé, 2020/06/05
- [PATCH v5 09/11] accel/Kconfig: Add the TCG selector, Philippe Mathieu-Daudé, 2020/06/05
- [PATCH v5 10/11] Makefile: Allow target-specific optional Kconfig, Philippe Mathieu-Daudé, 2020/06/05
- [PATCH v5 11/11] accel/tcg: Add stub for probe_access(), Philippe Mathieu-Daudé, 2020/06/05
- Re: [PATCH v5 11/11] accel/tcg: Add stub for probe_access(),
David Hildenbrand <=