Re: [PATCH] replay: fix replay shutdown for console mode

[Paolo Bonzini]

On 22/05/20 08:45, Pavel Dovgalyuk wrote:
> When QEMU is used without any graphical window,
> QEMU execution is terminated with the signal (e.g., Ctrl-C).
> Signal processing in QEMU does not include
> qemu_system_shutdown_request call. That is why shutdown
> event is not recorded by record/replay in this case.
> This patch adds shutdown event to the end of the record log.
> Now every replay will shutdown the machine at the end.
> 
> Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
> ---
>  0 files changed
> 
> diff --git a/replay/replay.c b/replay/replay.c
> index 53edad1377..83ed9e0e24 100644
> --- a/replay/replay.c
> +++ b/replay/replay.c
> @@ -366,6 +366,11 @@ void replay_finish(void)
>      /* finalize the file */
>      if (replay_file) {
>          if (replay_mode == REPLAY_MODE_RECORD) {
> +            /*
> +             * Can't do it in the signal handler, therefore
> +             * add shutdown event here for the case of Ctrl-C.
> +             */
> +            replay_shutdown_request(SHUTDOWN_CAUSE_HOST_SIGNAL);
>              /* write end event */
>              replay_put_event(EVENT_END);
>  
> 

Queued, thanks.

Paolo