[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/13] i386: hvf: Use ins_len to advance IP
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH 05/13] i386: hvf: Use ins_len to advance IP |
|
Date: |
Thu, 4 Jun 2020 20:15:06 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 04/06/20 08:39, Philippe Mathieu-Daudé wrote:
>> simulate_wrmsr(cpu);
>> }
>> - RIP(env) += rvmcs(cpu->hvf_fd, VMCS_EXIT_INSTRUCTION_LENGTH);
>> + RIP(env) += ins_len;
> I'd feel safer if you change ins_len to uint64_t first.
>
Why? It will never be more than 15 (it's also a 32-bit field in the VMCS).
Paolo