[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/9] target/i386: sev: Partial cleanup to sev_state global
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 5/9] target/i386: sev: Partial cleanup to sev_state global |
Date: |
Thu, 4 Jun 2020 08:52:34 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 6/4/20 8:42 AM, David Gibson wrote:
> The SEV code uses a pretty ugly global to access its internal state. Now
> that SEVState is embedded in SevGuestState, we can avoid accessing it via
> the global in some cases. In the remaining cases use a new global
> referencing the containing SevGuestState which will simplify some future
> transformations.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/i386/sev.c | 92 ++++++++++++++++++++++++-----------------------
> 1 file changed, 48 insertions(+), 44 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
- [PATCH 0/9] AMD SEV: Cleanup state handling, David Gibson, 2020/06/04
- [PATCH 1/9] target/i386: sev: Remove unused QSevGuestInfoClass, David Gibson, 2020/06/04
- [PATCH 4/9] target/i386: sev: Embed SEVState in SevGuestState, David Gibson, 2020/06/04
- [PATCH 2/9] target/i386: sev: Move local structure definitions into .c file, David Gibson, 2020/06/04
- [PATCH 6/9] target/i386: sev: Remove redundant cbitpos and reduced_phys_bits fields, David Gibson, 2020/06/04
- [PATCH 5/9] target/i386: sev: Partial cleanup to sev_state global, David Gibson, 2020/06/04
- Re: [PATCH 5/9] target/i386: sev: Partial cleanup to sev_state global,
Philippe Mathieu-Daudé <=
- [PATCH 8/9] target/i386: sev: Remove redundant handle field, David Gibson, 2020/06/04
- [PATCH 9/9] target/i386: sev: Unify SEVState and SevGuestState, David Gibson, 2020/06/04
- [PATCH 3/9] target/i386: sev: Rename QSevGuestInfo, David Gibson, 2020/06/04
- [PATCH 7/9] target/i386: sev: Remove redundant policy field, David Gibson, 2020/06/04
- Re: [PATCH 0/9] AMD SEV: Cleanup state handling, Paolo Bonzini, 2020/06/04