qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 00/16] python: add mypy support to python/qemu


From: Eric Blake
Subject: Re: [PATCH v2 00/16] python: add mypy support to python/qemu
Date: Tue, 2 Jun 2020 16:51:13 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0

On 6/2/20 4:45 PM, John Snow wrote:
Requires: 20200602194844.15258-1-jsnow@redhat.com

I don't know if patchew understand that, or if it requires:

Based-on: 20200602194844.15258-1-jsnow@redhat.com


This series is extracted from my larger series that attempted to bundle
our python module as an installable module. These fixes don't require that,
so they are being sent first as I think there's less up for debate in here.

This requires my "refactor shutdown" patch as a pre-requisite.

"v2":
- This version supports iotests 297
- Many patches merged by Phil are removed
- Replaces iotests.py type aliases with centralized ones
   (See patch 2)
- Imports etc are reworked to use the non-installable
   package layout instead. (Mostly important for patch 3)

Testing this out:
- You'll need Python3.6+
- I encourage you to use a virtual environment!
- You don't necessarily need these exact versions, but I didn't test the
   lower bounds, use older versions at your peril:
   - pylint==2.5.0
   - mypy=0.770
   - flake8=3.7.8

cd ~/src/qemu/python/
flake8 qemu
mypy --strict qemu
cd qemu
pylint *.py

These should all 100% pass.

---

Open RFC: What's the right way to hook this into make check to prevent
regressions?

We recently added iotest 297 in group meta; is there a way to run './check -g meta' alongside the other iotests that 'make check' already triggers?

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]