Re: [PULL 04/12] hmp: Simplify qom-set

[Dr. David Alan Gilbert]

* Markus Armbruster (armbru@redhat.com) wrote:
> "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> writes:
> 
> > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> >
> > Simplify qom_set by making it use qmp_qom_set and the JSON parser.
> >
> > (qemu) qom-get /machine smm
> > "auto"
> > (qemu) qom-set /machine smm "auto"
> >
> > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> > Message-Id: <20200520151108.160598-3-dgilbert@redhat.com>
> > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > Reviewed-by: Markus Armbruster <armbru@redhat.com>
> > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> >   With 's'->'S' type change suggested by Paolo and Markus
> 
> This is actually more than just simplification, it's disarming a bear
> trap: the string visitor is restricted to a subset of the QAPI types,
> and when you qom-set a property with a type it can't handle, QEMU
> aborts.  I mentioned this in the discussion of possible ways out of the
> qom-get impasse, but missed reraising it in patch review.
> 
> A suitably amended commit would be nice, but respinning the PR just for
> that may not be worthwhile.

A bit late; still as long as we're removing bear traps not adding them.

Dave

--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK